Open
Conversation
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially a duplicate of this PR: #179
I left MetaMask so I couldn't commit the markdown file to that branch anymore.
The goal of this SIP is to create a hook that fires when a user clicks on an activity item (past transaction) to view the transaction. It would offer similar functionality to the
onTransactionandonSignaturehooks, and be useful for post-transaction use cases (eg feedback about an address, display info / receipt for a purchased product, or other call-to-actionsNote
Low Risk
Documentation-only change that adds a new draft SIP; no runtime code or existing specs are modified, so risk is limited to potential spec/permission design issues before adoption.
Overview
Adds draft SIP-34 proposing a new Snap lifecycle hook,
onActivityItem, to surface UI insights when a user opens an Activity (history) item.Defines a new permission
endowment:activity-insight(with optionalallowActivityOrigincaveat) and specifies the handler args/return types including transaction metadata, status, optional receipt/hash, and origin.Written by Cursor Bugbot for commit 942fa93. This will update automatically on new commits. Configure here.